From 6a06288d8c841d9ca32d2b3fb88647c8658c0534 Mon Sep 17 00:00:00 2001 From: efernandez Date: Wed, 26 Dec 2018 17:56:13 -0300 Subject: [PATCH] code review --- src/js/arrastrar.js | 4 ++-- src/js/controller.js | 2 +- src/js/controllerDetalleVehiculo.js | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/js/arrastrar.js b/src/js/arrastrar.js index 1f17c02..f2ab03d 100644 --- a/src/js/arrastrar.js +++ b/src/js/arrastrar.js @@ -19,7 +19,7 @@ function drop(ev) { } function dropEnd() { console.log('drop'); - var elementoDom = document.getElementById('test'); + var elementoDom = document.getElementById('test'); var scope = angular.element(elementoDom).scope(); scope.noArrastra(); -} \ No newline at end of file +} diff --git a/src/js/controller.js b/src/js/controller.js index 981cc26..a8b2138 100644 --- a/src/js/controller.js +++ b/src/js/controller.js @@ -119,7 +119,7 @@ angular.module('focaLogisticaPedidoRuta') .controller('focaLogisticaPedidoRutaCo modalInstance.result.then( function(vehiculo) { var existe = $filter('filter')($scope.vehiculos, {id: vehiculo.id}); - if(existe.length > 0){ + if(existe.length) { focaModalService.alert('El vehiculo que intenta cargar ya ha sido cargado'); return; } diff --git a/src/js/controllerDetalleVehiculo.js b/src/js/controllerDetalleVehiculo.js index 8e61934..a451d54 100644 --- a/src/js/controllerDetalleVehiculo.js +++ b/src/js/controllerDetalleVehiculo.js @@ -34,7 +34,7 @@ angular.module('focaLogisticaPedidoRuta') }; $scope.cargarACisternas = function(vehiculo) { - for (var i = 0; i < vehiculo.cisternas.length; i++) { + for(var i = 0; i < vehiculo.cisternas.length; i++) { var cisterna = vehiculo.cisternas[i]; var aCargar = parseFloat($scope.aCargar[i]); if(!aCargar) { @@ -66,7 +66,7 @@ angular.module('focaLogisticaPedidoRuta') return filter.cargado !== true; } ); - if(articuloSiguiente.length > 0){ + if(articuloSiguiente.length > 0) { $scope.cambioArticulo(articuloSiguiente[0]); } $scope.aCargar = []; -- 1.9.1